fix: Strip common arch-specific flags before processing #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes the argument dropping mechanism used specifically
for nvcc to also work for Clang and GCC, and skips some
known arch-specific flags for Clang and GCC, to reduce risk
of unknown flags hit in practice on other architectures.
Fixes GRAPH-1187. See comments for more context.
I've not added a full-blown mechanism to skip arbitrary flags
(e.g. via an extra flag), but we could do that later if necessary.
Added some basic unit tests at the level of the command-line
tweaking. It's a bit more difficult to test this logic at a higher-level,
because the layer above it does I/O for compiler detection.