Skip to content

fix: Strip common arch-specific flags before processing #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented May 8, 2025

Generalizes the argument dropping mechanism used specifically
for nvcc to also work for Clang and GCC, and skips some
known arch-specific flags for Clang and GCC, to reduce risk
of unknown flags hit in practice on other architectures.

Fixes GRAPH-1187. See comments for more context.

I've not added a full-blown mechanism to skip arbitrary flags
(e.g. via an extra flag), but we could do that later if necessary.

Added some basic unit tests at the level of the command-line
tweaking. It's a bit more difficult to test this logic at a higher-level,
because the layer above it does I/O for compiler detection.

@varungandhi-src varungandhi-src force-pushed the vg/skip-arch-flags branch 3 times, most recently from 62dc778 to 5829b50 Compare May 8, 2025 13:24
@varungandhi-src
Copy link
Contributor Author

Merging now so that we can cut a release.

@varungandhi-src varungandhi-src merged commit a186c53 into main May 8, 2025
1 check passed
@varungandhi-src varungandhi-src deleted the vg/skip-arch-flags branch May 8, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant