Closed
Description
When looking at the shopify-api-ruby repo, we don't seem to be emitting correct package names for references. For example, the shopify_api.rb file references zeitwerk and a class from it, but the emitted reference contains shopify_api as the package name. I think it is likely messed up because I wasn't diligent about checking the source location here:
https://github.com/sourcegraph/scip-ruby/blob/scip-ruby/master/scip_indexer/SCIPSymbolRef.cc#L50
When that function is called from saveReference, we may be passed in the source location for the reference, not the definition. But we need to base the package name based on the defining file.