-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add support for manually specifiying gems for cross-repo. #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eb1b808
to
6a245ca
Compare
6a245ca
to
3790e4b
Compare
Interesting; if I put a print statement inside https://github.com/sorbet/sorbet/tree/master/rbi/stdlib/yaml.rbi |
3790e4b
to
b89f004
Compare
OK, so this does seem to be working OK for basic file lists, but the fallback to the |
b89f004
to
6c6d268
Compare
3fa112c
to
65d17ac
Compare
65d17ac
to
57c8eac
Compare
57c8eac
to
b1e47b0
Compare
@@ -35,7 +35,6 @@ def m2 | |||
end | |||
|
|||
sig { params(C, T::Boolean).returns(T::Boolean) } | |||
# ^ reference [..] `T.untyped`# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm, why is this 'C' and not 'C1' and why are parameter types missing?
Motivation
This would help customers specify cross-repo mappings in an easy way
even when our inference fails.
Test plan
Add test for the stdlib version being used.We aren't using specific versions, we can add that later.