AssertionError [ERR_ASSERTION]: false == true

[misterfresh]

I get the error
assert.js:60
throw new errors.AssertionError({
at PriorityNode.removeChild (node_modules\spdy-transport\lib\spdy-transport\priority.js:74:3)
at PriorityNode.remove ( node_modules\spdy-transport\lib\spdy-transport\priority.js:62:15)
at PriorityTree.add ( node_modules\spdy-transport\lib\spdy-transport\priority.js:163:23)
at Stream._initPriority ( node_modules\spdy-transport\lib\spdy-transport\stream.js:101:25)
at new Stream ( node_modules\spdy-transport\lib\spdy-transport\stream.js:76:8)
at Connection._createStream ( node_modules\spdy-transport\lib\spdy-transport\connection.js:388:16)
at Connection._handleHeaders ( node_modules\spdy-transport\lib\spdy-transport\connection.js:436:21)
at Connection._handleFrame ( node_modules\spdy-transport\lib\spdy-transport\connection.js:319:10)
at Parser. ( node_modules\spdy-transport\lib\spdy-transport\connection.js:156:10)
at emitOne (events.js:115:13)
at Parser.emit (events.js:210:7)
at addChunk ( node_modules\readable-stream\lib_stream_readable.js:283:12)
at readableAddChunk ( node_modules\readable-stream\lib_stream_readable.js:270:11)
at Parser.Readable.push ( node_modules\readable-stream\lib_stream_readable.js:237:10)
at Parser.Transform.push ( node_modules\readable-stream\lib_stream_transform.js:146:32)
at next ( node_modules\spdy-transport\lib\spdy-transport\protocol\base\parser.js:53:12)

This happens on http2 push from server

[misterfresh]

I commented the line 74 "assert(index !== -1)" in spdy-transport\lib\spdy-transport\priority.js:74:3
and now the server is not crashing any more...

To give context, I am pushing a lot of files with http2 push, and for every file that is not actually requested by the client, I get the error
link /js/vendors/aphrodite push error Error: Got RST: REFUSED_STREAM
at Stream._handleRST ( node_modules\spdy-transport\lib\spdy-transport\stream.js:281:24)
at Stream._handleFrame ( node_modules\spdy-transport\lib\spdy-transport\stream.js:126:10)
at Connection._handleFrame ( node_modules\spdy-transport\lib\spdy-transport\connection.js:324:12)
at Parser. ( node_modules\spdy-transport\lib\spdy-transport\connection.js:156:10)
at emitOne (events.js:115:13)
at Parser.emit (events.js:210:7)
at addChunk ( node_modules\readable-stream\lib_stream_readable.js:283:12)
at readableAddChunk ( node_modules\readable-stream\lib_stream_readable.js:270:11)
at Parser.Readable.push ( node_modules\readable-stream\lib_stream_readable.js:237:10)
at Parser.Transform.push ( node_modules\readable-stream\lib_stream_transform.js:146:32)
at next ( node_modules\spdy-transport\lib\spdy-transport\protocol\base\parser.js:53:12)
at node_modules\spdy-transport\lib\spdy-transport\protocol\http2\parser.js:72:5
at Parser.onRSTFrame (node_modules\spdy-transport\lib\spdy-transport\protocol\http2\parser.js:368:3)
at Parser.onFrameBody ( node_modules\spdy-transport\lib\spdy-transport\protocol\http2\parser.js:144:10)
at Parser.execute ( node_modules\spdy-transport\lib\spdy-transport\protocol\http2\parser.js:64:8)
at Parser._consume ( node_modules\spdy-transport\lib\spdy-transport\protocol\base\parser.js:95:8)

[matthewp]

I submitted #48 which should fix your issue here.

[misterfresh]

With your fix, I'm getting a slightly different error, but the server still crashes when a resource pushed by http2 server push is not requested by the client.

assert.js:60
throw new errors.AssertionError({
^

AssertionError [ERR_ASSERTION]: false == true
at PriorityNode.removeChild ( node_modules\spdy-transport\lib\spdy-transport\priority.js:74:3)
at PriorityNode.remove ( node_modules\spdy-transport\lib\spdy-transport\priority.js:62:15)
at Stream._handlePriority ( node_modules\spdy-transport\lib\spdy-transport\stream.js:305:18)
at Stream._handleFrame ( node_modules\spdy-transport\lib\spdy-transport\stream.js:128:10)
at Connection._handleFrame ( node_modules\spdy-transport\lib\spdy-transport\connection.js:324:12)
at Parser. ( node_modules\spdy-transport\lib\spdy-transport\connection.js:156:10)
at emitOne (events.js:115:13)
at Parser.emit (events.js:210:7)
at addChunk ( node_modules\readable-stream\lib_stream_readable.js:283:12)
at readableAddChunk ( node_modules\readable-stream\lib_stream_readable.js:270:11)
at Parser.Readable.push ( node_modules\readable-stream\lib_stream_readable.js:237:10)
at Parser.Transform.push ( node_modules\readable-stream\lib_stream_transform.js:146:32)
at next ( node_modules\spdy-transport\lib\spdy-transport\protocol\base\parser.js:53:12)
at node_modules\spdy-transport\lib\spdy-transport\protocol\http2\parser.js:72:5
at Parser.onPriorityFrame ( node_modules\spdy-transport\lib\spdy-transport\protocol\http2\parser.js:539:3)
at Parser.onFrameBody ( node_modules\spdy-transport\lib\spdy-transport\protocol\http2\parser.js:154:10)

[matthewp]

@misterfresh I have noticed that as well. My fix fixes some of the issues but the error can still happen if there is a PRIORITY frame and the node has already been removed. So it needs to check in that spot as well if the node is part of the tree.

[Jaeiya]

Is there a workaround for this?
I just loaded up my webapp in firefox and got this error. For some reason I do not get this error when opening in Chrome.

[misterfresh]

Here's a temporary fix : in your project's main package.json add:

"scripts": {
    "postinstall": "node ./conf/quickfix.js"
}

and in the quickfix.js file :

let fs = require('fs')
let path = require('path')
let file = path.join(
    process.cwd(),
    'node_modules/spdy-transport/lib/spdy-transport/priority.js'
)

let data = fs
    .readFileSync(file)
    .toString()
    .split('\n')
if (data.length < 190) {
    data.splice(73, 0, '/*')
    data.splice(75, 0, '*/')
    data.splice(
        187,
        0,
        `
	var index = utils.binarySearch(this.list, node, compareChildren);
 	this.list.splice(index, 1);
`
    )
    let text = data.join('\n')

    fs.writeFile(file, text, function(err) {
        if (err) return console.log(err)
    })
}

now everytime you install spdy it will be patched if needed.

also node-http2 native is available, just not yet compatible with express

[Jaeiya]

Thanks for this.
Do you know when the native will be compatible with express?

[misterfresh]

no... there is an issue on it but I dont think they have a date yet

[th3nate]

hello,
im experiencing the same issue,
although using node-spdy im getting the same error about the transport module with version 2.0.20
was this issue fixed in the newest version?

AssertionError [ERR_ASSERTION]: false == true
at PriorityNode.removeChild (/app/node_modules/spdy-transport/lib/spdy-transport/priority.js:74:3)
at PriorityNode.remove (/app/node_modules/spdy-transport/lib/spdy-transport/priority.js:62:15)
at Stream._handlePriority (/app/node_modules/spdy-transport/lib/spdy-transport/stream.js:305:18)
at Stream._handleFrame (/app/node_modules/spdy-transport/lib/spdy-transport/stream.js:128:10)
at Connection._handleFrame (/app/node_modules/spdy-transport/lib/spdy-transport/connection.js:324:12)
at Parser. (/app/node_modules/spdy-transport/lib/spdy-transport/connection.js:156:10)
at emitOne (events.js:116:13)
at Parser.emit (events.js:211:7)
at addChunk (/app/node_modules/readable-stream/lib/_stream_readable.js:284:12)
at readableAddChunk (/app/node_modules/readable-stream/lib/_stream_readable.js:271:11)
at Parser.Readable.push (/app/node_modules/readable-stream/lib/_stream_readable.js:238:10)
at Parser.Transform.push (/app/node_modules/readable-stream/lib/_stream_transform.js:146:32)
at next (/app/node_modules/spdy-transport/lib/spdy-transport/protocol/base/parser.js:53:12)
at /app/node_modules/spdy-transport/lib/spdy-transport/protocol/http2/parser.js:72:5

UPDATE:
updated the pkg to 2.1.0 but still the issue exists.
so now I've reverted back to 2.0.20 and used the patch from the previous comment, ill share if it solved the issue.

if anyone has a better idea i'd greatly appreciate it,
thanks!

[wmertens]

How about just replacing the assert(index !== -1) with if (index === -1) return? Seems unsafe to let the function remove the last child from the list…

[vytautas-pranskunas-]

Any progress on this one? Or SPDY package with 100k weekly downloads has ment to be used with hacks and memory leaks?