chore: ADDON-80802 Updated the search query for test_requirements_fields test of PSA #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-improvement
branch
from
a3404c1 to
9c51720
Compare
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-improvement
branch
from
9c51720 to
dc1ca8e
Compare
mgazda-splunk
previously approved these changes
May 20, 2025
There was a problem hiding this comment.
For me proposed change looks OK. Wondering if we need to provide any more tests/confirm it works fine with few TAs?
Also wondering if this should be default and only option? Cannot imagine now why not, however, would consider if using _raw makes any benefit over UUID.
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-improvement
branch
4 times, most recently
from
90c8c52 to
183d768
Compare
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-improvement
branch
from
183d768 to
26c0b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PSA uses the raw event in the search query for the “test_requirements_fields” test. So, in order to run the test for SPL2 transformed events, the logs repo samples needs to be updated with the SPL2 transformed logs. To avoid updating the logs repo samples, we can update the search query in PSA to use a unique uuid instead of using the raw event.
Updated the unit testcases
JIRA: https://splunk.atlassian.net/browse/ADDON-80802