Skip to content

Document that formatter does not order imports #77

@ttddyy

Description

@ttddyy

Should this plugin re-order import statements?

In spring-boot project,

This is the one passing ./mvnw validate

import java.time.Duration;
import java.util.Collections;
import java.util.Set;

import org.junit.Test;
import org.mockito.InOrder;

import org.springframework.transaction.PlatformTransactionManager;
import org.springframework.transaction.TransactionDefinition;
import org.springframework.transaction.annotation.Isolation;
import org.springframework.transaction.annotation.Propagation;
import org.springframework.transaction.support.TransactionTemplate;

I swapped java.time.Duration and java.util.Collections, then ran ./mvnw io.spring.javaformat:spring-javaformat-maven-plugin:apply

Nothing changed in import ordering, and ./mvnw validate failes on checkstyle.

Also, on Intellij with spring-javaformat plugin, when I do "Optimise Import", it shuffles import like this:

import org.junit.Test;
import org.mockito.InOrder;
import org.springframework.transaction.PlatformTransactionManager;
import org.springframework.transaction.TransactionDefinition;
import org.springframework.transaction.annotation.Isolation;
import org.springframework.transaction.annotation.Propagation;
import org.springframework.transaction.support.TransactionTemplate;

import java.time.Duration;
import java.util.Collections;
import java.util.Set;

This also fails on checkstyle.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions