-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DATAREDIS-988 - Consider transaction participation when releasing connections. #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now check on connection release whether a connection is in MULTI state. If so, then we discard (rollback) the transaction to reset the connection to a fresh state.
…nections. We now consider RedisTemplate's enableTransactionSupport configuration when releasing connections. Previously, we released bound connections when being in a read-only transaction regardless the configuration in RedisTemplate. This broke session callbacks that expected to remain on the same connection all but the first command were executed on a different connection. Releasing a connection now no longer unbinds a connection if transaction support is disabled.
|
ping |
christophstrobl
pushed a commit
that referenced
this pull request
Jul 3, 2019
We now check on connection release whether a connection is in MULTI state. If so, then we discard (rollback) the transaction to reset the connection to a fresh state. Original Pull Request: #453
christophstrobl
pushed a commit
that referenced
this pull request
Jul 3, 2019
…nections. We now consider RedisTemplate's enableTransactionSupport configuration when releasing connections. Previously, we released bound connections when being in a read-only transaction regardless the configuration in RedisTemplate. This broke session callbacks that expected to remain on the same connection all but the first command were executed on a different connection. Releasing a connection now no longer unbinds a connection if transaction support is disabled. Original Pull Request: #453
christophstrobl
added a commit
that referenced
this pull request
Jul 3, 2019
Original Pull Request: #453
christophstrobl
pushed a commit
that referenced
this pull request
Jul 3, 2019
We now check on connection release whether a connection is in MULTI state. If so, then we discard (rollback) the transaction to reset the connection to a fresh state. Original Pull Request: #453
christophstrobl
pushed a commit
that referenced
this pull request
Jul 3, 2019
…nections. We now consider RedisTemplate's enableTransactionSupport configuration when releasing connections. Previously, we released bound connections when being in a read-only transaction regardless the configuration in RedisTemplate. This broke session callbacks that expected to remain on the same connection all but the first command were executed on a different connection. Releasing a connection now no longer unbinds a connection if transaction support is disabled. Original Pull Request: #453
christophstrobl
added a commit
that referenced
this pull request
Jul 3, 2019
Original Pull Request: #453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now check on connection release whether a connection is in
MULTI
state. If so, then we discard (rollback) the transaction to reset the connection to a fresh state.We now consider RedisTemplate's
enableTransactionSupport
configuration when releasing connections. Previously, we released bound connections when being in a read-only transaction regardless of the configuration inRedisTemplate
. This broke session callbacks that expected to remain on the same connection all but the first command were executed on a different connection.Releasing a connection now no longer unbinds a connection if transaction support is disabled.
Related ticket: DATAREDIS-988.
Should be forward-ported.