-
Notifications
You must be signed in to change notification settings - Fork 38.6k
Closed
Labels
in: coreIssues in core modules (aop, beans, core, context, expression)Issues in core modules (aop, beans, core, context, expression)status: backportedAn issue that has been backported to maintenance branchesAn issue that has been backported to maintenance branchestype: enhancementA general enhancementA general enhancement
Milestone
Description
In the various hint related classes, there's a mixture of using ClassUtils.getDefaultClassLoader()
and the hint class's own class loader:
ClassUtils.getDefaultClassLoader()
:
ReflectionHints
ObjectToObjectConverterRuntimeHints
(delegates toReflectionHints
)
getClass().getClassLoader()
:
FilePatternResourceHintsRegistrar
ResourceHints
SpringFactoriesLoaderRuntimeHints
For consistency, I think the same default class loader should be used. My preference would be to use ClassUtils.getDefaultClassLoader()
.
In addition to the inconsistency across hints classes, it looks like SpringFactoriesLoaderRuntimeHints
is inconsistent with SpringFactoriesLoader
as the latter will use ClassUtils.getDefaultClassLoader()
.
Metadata
Metadata
Assignees
Labels
in: coreIssues in core modules (aop, beans, core, context, expression)Issues in core modules (aop, beans, core, context, expression)status: backportedAn issue that has been backported to maintenance branchesAn issue that has been backported to maintenance branchestype: enhancementA general enhancementA general enhancement