Skip to content

Fix deprecations around ListenableFuture #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artembilan
Copy link
Member

SF has deprecated a ListenableFuture and API around it

  • Migrate to CompletableFuture everywhere a ListenableFuture has been used
  • Suppress a deprecation for ListenableFuture keeping the functionality until the next version
  • Resolve deprecations nad removals from the latest Spring for Apache Kafka
  • Fix documentation for the ListenableFuture in favor of CompletableFuture

NOTE: the AMQP module is left as is until ListenableFuture deprecation is resolved in Spring AMQP

SF has deprecated a `ListenableFuture` and API around it

* Migrate to `CompletableFuture` everywhere a `ListenableFuture` has been used
* Suppress a deprecation for `ListenableFuture` keeping the functionality until the next version
* Resolve deprecations nad removals from the latest Spring for Apache Kafka
* Fix documentation for the `ListenableFuture` in favor of `CompletableFuture`

NOTE: the AMQP module is left as is until `ListenableFuture` deprecation is resolved in Spring AMQP
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

@garyrussell garyrussell merged commit 5572c21 into spring-projects:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants