"object not found" iterating over all trees in a repository (dangling temporary object)

[erizocosmico]

Using the following script I get "object not found"

package main

import (
	"fmt"
	"io"
	"log"

	git "gopkg.in/src-d/go-git.v4"
)

func main() {
	r, err := git.PlainOpen(".")
	assert(err)

	trees, err := r.TreeObjects()
	assert(err)

	for {
		t, err := trees.Next()
		if err == io.EOF {
			break
		}

		assert(err)

		fmt.Println(t.Hash)
	}
}

func assert(err error) {
	if err != nil {
		log.Fatal(err)
	}
}

As you can see, I'm just opening a repo and iterating over all its trees, nothing very fancy here.

It happens on my local copy of https://github.com/src-d/gitbase, but not on a freshly cloned copy (even with all branches downloaded). I can upload a zip of the current state of the repo if that's needed for debug.

[smola]

@erizocosmico If you send me a zipped copy of your repo (e.g. through Slack), I'll give it a try.

[erizocosmico]

Sent through slack

[smola]

The problem is that there is a dangling temporary object at .git/objects/3c/tmp_obj_qEZcJb, which then produces the following inner error open /tmp/gitbase-wrong/.git/objects/3c/00000000000000000000000000000000000000: no such file ordirectory.

It is a bug in the dotgit package, around these lines:

go-git/storage/filesystem/dotgit/dotgit.go

Line 261 in 9f00789

h := plumbing.NewHash(base + o.Name())