-
-
Notifications
You must be signed in to change notification settings - Fork 7
fix(spark-anomaly-detection): Adjust Trino HTTPS connection #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maltesander
merged 13 commits into
main
from
spark-anomaly-detection/fix-superset-trino-https
Jul 16, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
34f1ae3
wip
maltesander bcd526a
fix assert zip content
maltesander 4792fe0
fix zip
maltesander ec2c3e2
fix zip 2
maltesander db1b959
use main branch zip
maltesander 67ba6e2
set version back to 4.1.2
maltesander 5c1521d
Merge branch 'main' into spark-anomaly-detection/fix-superset-trino-h…
maltesander e1c175e
Apply suggestions from code review
maltesander 14c88be
Update demos/spark-k8s-anomaly-detection-taxi-data/setup-superset.yaml
maltesander c14189b
use listener service instead of headless
maltesander 720ab8b
Merge branch 'main' into spark-anomaly-detection/fix-superset-trino-h…
maltesander 94a2077
Merge branch 'main' into spark-anomaly-detection/fix-superset-trino-h…
maltesander 27f154c
Merge branch 'main' into spark-anomaly-detection/fix-superset-trino-h…
maltesander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+5.2 KB
(220%)
demos/spark-k8s-anomaly-detection-taxi-data/superset-assets.zip
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should remember to copy this zip to other demos that have one (though I'm unsure if they are all equal). |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,8 +26,8 @@ stringData: | |
adminUser.firstname: Superset | ||
adminUser.lastname: Admin | ||
adminUser.email: [email protected] | ||
adminUser.password: {{ supersetAdminPassword }} | ||
connections.secretKey: {{ supersetSecretKey }} | ||
adminUser.password: "{{ supersetAdminPassword }}" | ||
connections.secretKey: "{{ supersetSecretKey }}" | ||
connections.sqlalchemyDatabaseUri: postgresql://superset:superset@postgresql-superset/superset | ||
--- | ||
apiVersion: v1 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is typo here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more specific?
Is the indentation a problem? ie:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
sets.zip
is too much and it looks like a left over that breaks the curl outputThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#253