Skip to content

Map ListenerClass.spec.loadBalancerClass into Service.spec #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 28, 2025

Conversation

nightkr
Copy link
Contributor

@nightkr nightkr commented Mar 19, 2025

Description

Fixes #285, requires stackabletech/operator-rs#986

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@nightkr nightkr marked this pull request as ready for review May 27, 2025 09:18
@nightkr
Copy link
Contributor Author

nightkr commented May 27, 2025

@nightkr nightkr requested a review from a team May 27, 2025 09:46
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 5d97d9e May 28, 2025
16 of 17 checks passed
@nightkr nightkr deleted the feature/loadbalancerclass branch May 28, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom loadBalancerClass
2 participants