-
-
Notifications
You must be signed in to change notification settings - Fork 859
feat: add support for auto-closing brackets/quotations in the REPL #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
3431b3c
feat: add auto-closing brackets & quotations in REPL
Snehil-Shah 81d3b7d
feat: add option to toggle auto-closing behavior
Snehil-Shah 3fbdd4e
refactor: prevent use of private readline methods
Snehil-Shah 3f5f685
feat: add generic `settings` command to manage all settings
Snehil-Shah a6bc4e2
fix: remove autoClose from defaults
Snehil-Shah d8716d7
fix: remove `autoClose` from REPL opts
Snehil-Shah 3ed9eff
fix: error messages
Snehil-Shah 7b7009b
feat: manual multiline mode from cursor position
Snehil-Shah d0c66c6
remove unused flag
Snehil-Shah 8278728
feat: handle instinctive closing symbols for improved ergonomics
Snehil-Shah e4884e5
refactor: suggestions
Snehil-Shah 1202732
feat: add auto indentation
Snehil-Shah db50041
feat: handle special cases to improve ergonomics
Snehil-Shah 15821a5
Merge branch 'develop' of https://github.com/stdlib-js/stdlib into sn…
kgryte db29963
fix: consolidate keypress listeners
kgryte 19ef85b
refactor: always attach a keypress listener
kgryte 6b865c9
refactor: document `settings` command signatures
kgryte 35ec9b7
refactor: document defaults and add settings object
kgryte 357431a
refactor: add module exposing settings validators
kgryte 6e75e67
refactor: add module to validate a settings object
kgryte 85687d3
fix: update error messages
kgryte 89f9802
fix: add missing settings file
kgryte e70d3db
docs: update comment
kgryte 8c5f3cd
refactor: add support for validating a settings object
kgryte 6021d0f
refactor: remove duplicate option setting and document settings
kgryte 4ea8a03
refactor: make the default dependent on whether TTY
kgryte 5786c14
style: disable lint rules
kgryte 3747888
docs: document settings
kgryte 1595697
refactor: add module exporting a list of settings names
kgryte 5e54ec5
refactor: use module to get list of settings names
kgryte 3de8ec5
refactor: update help text generation
kgryte fd3b2a9
refactor: only pass down settings object
kgryte 02fad69
fix: use setting name when constructing error message
kgryte 9dfa13c
refactor: add module to test if a value is a setting name
kgryte 0d8d3a9
refactor: update error messages
kgryte 22aba0c
feat: add `settings` method for getting and setting REPL settings
kgryte 2dff629
refactor: delegate to `settings` method to validate arguments
kgryte 9f35dff
docs: document `settings` method
kgryte d8da17a
refactor: handle returning setting value as would normal command
kgryte 336d7a0
refactor: update confirmation message
kgryte d00958e
docs: update description
kgryte 7e8f592
refactor: remove support for manually entering multi-line editing
kgryte 590649d
docs: update copy
kgryte 89415bc
refactor: bind variables to REPL instance to allow "toggabilty"
kgryte 0f577cc
refactor: move symbols table to separate file
kgryte d4e0730
fix: update require path
kgryte 1f14f24
refactor: convert auto-matcher to a class
kgryte e4f50ba
refactor: make private properties read-only
kgryte 53ae830
fix: only perform preview completion when no collisions are possible
kgryte 0af02a2
refactor: clean implementation with scoped variables
kgryte acc8ab6
refactor: use helper functions
kgryte 0c55033
docs: add FIXME
kgryte ec2c283
refactor: add modules for specifying settings arguments amenable to a…
kgryte 5212dcc
refactor: add module exporting a regexp for matching settings APIs
kgryte da738c4
refactor: add support for settings name auto-completion
kgryte a90fc2d
refactor: defer to completer when receiving a TAB character
kgryte 0059b77
refactor: use internal utility to support suppressing log messages
kgryte 5e26c45
refactor: reorder cases in alphabetical order
kgryte 98364f6
refactor: fix order
kgryte ab671c2
refactor: update implementation to use AST
kgryte 691b45b
style: add lint warnings
kgryte cc6627b
style: address lint warning
kgryte 1be8b6b
test: add auto-match tests and move fixture
kgryte ec672ab
refactor: rename setting
kgryte 5434e3b
docs: rename setting
kgryte 1ff156f
refactor: remove unused property
kgryte 662e1cf
fix: update property name
kgryte 6d8390d
fix: allow auto-closing within template and object expressions
kgryte 8e09e8e
test: add RegExp test
kgryte 8f9dce8
fix: address completer bug when completing after special characters
kgryte 0bb6ae9
refactor: add support for auto-deleting character pairs
kgryte c6d997d
refactor: move deletion logic to auto-closer due to shared state
kgryte d0d1dbf
fix: ensure corresponding closing symbol when auto-deleting pairs
kgryte d3fd4ef
docs: update copy
kgryte ff0a086
docs: fix jsdoc
Snehil-Shah 10de907
test: add tests for auto-deletion
Snehil-Shah 2ae5f73
Merge branch 'stdlib-js:develop' into repl
Snehil-Shah 2f53984
Revert "docs: fix jsdoc"
Snehil-Shah a1477a3
test: fix tests
Snehil-Shah 6ab1028
refactor: separate auto-delete & auto-closing tests
Snehil-Shah 6b1f6f0
refactor: move conditional to the method itself
Snehil-Shah b8344c8
refactor: early return to avoid unnecessary indentation and rename pa…
kgryte d27f4c5
docs: document properties
kgryte a70003f
test: add separate test generation script
kgryte 0afd3b8
docs: update parameter type to reflect usage
kgryte b25fcaa
refactor: move regular expression to separate file
kgryte a960530
refactor: access preceding character directly
kgryte aee610c
refactor: replicate logic in private method
kgryte 5653b88
refactor: delegate open symbol processing to private method
kgryte f7cc5c7
refactor: copy logic for handling a closing symbol to a private method
kgryte badfc2c
refactor: delegate to private method for handling a closing symbol
kgryte 840e972
refactor: implement handling of opening symbol during auto-deletion i…
kgryte 52de42c
refactor: delegate to private method
kgryte 03b1fd0
docs: update param type
kgryte 24bb5cc
docs: fix copyright year
kgryte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.