TwoWire requestFrom(uint8_t address, size_t size, bool sendStop) Implementation

[aaron-neal]

I am having a Platformio build error with a library (ArduinoECCX08).

This is because it calls:

while (_wire->requestFrom((uint8_t)_address, (size_t)responseSize, (bool)true) != responseSize && retries--);

Where it s casting the sendStop paramater as a boolean, the compiler fails saying that it is ambiguous. The core does not appear to have the Arduino specific function as found here --> Link

Describe the solution you'd like
Implement a handler that better aligns with the arduino specfification --> Docs

Are there any guides I need to follow to implement a PR for this repo?

[fpistm]

Hi @porkyneal
Thanks for the PR.
This required some check. Looking at several Wire implementation in different core only the samd and megaavr have this one , that's why the library uses this prototyp as it is only compatible for those core.
Is the library works fine with your PR ?

[aaron-neal]

Hi @fpistm, I wasn't sure if it was worth a PR as obviously it is no bug, just an issue with this particular library casting to that exact defintion of requestFrom().

I guess if you are a stickler to align to the exact Arduino spec then it is required 🤷 ?

Yes, my project compiles and works with this change in Platformio.

[fpistm]

We will see how to answer this properly, maybe your PR is the best choice anyway I would like investigate to ensure no backward compatibility and also best integration.