Typo: MAX_ADC_RESOLUTION should be MAX_PWM_RESOLUTION ?

[AndrewBCN]

Hello,
in source file:
https://github.com/stm32duino/Arduino_Core_STM32/blob/master/cores/arduino/wiring_analog.c

line 123
_internalWriteResolution = MAX_ADC_RESOLUTION;

should (?) be
_internalWriteResolution = MAX_PWM_RESOLUTION;

since the max ADC resolution is irrelevant for the analogWrite function?

[fpistm]

Hi @AndrewBCN
Yes you are right.
Thank you for spotting this 👍

Hopefully MAX_ADC_RESOLUTION and MAX_PWM_RESOLUTION are equal in several case so no issue to use the analog write apis.

[AndrewBCN]

Yes, I spotted this by chance, while looking at how to set PWM resolution to 16 bits (the default is 8 bits, as you know). And MAX_ADC_RESOLUTION is 12 bits for the STM32F411CEU6, so that was a problem for me.