Skip to content

Wire: change definition of MASTER_ADDRESS to avoid potential conflict #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Jan 18, 2021

Wire: change definition of MASTER_ADDRESS to avoid potential conflict

Define MASTER_ADDRESS in Wire.cpp to avoid potential conflict
with other libraries.
Use 0x01 for master as it is reserved for START
and thus cannot be used by slave devices.

Fixes #1278

Define MASTER_ADDRESS in Wire.cpp to avoid potential conflict
with other libraries.
Use 0x01 for master as it is reserved for START
and thus cannot be used by slave devices.

Signed-off-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM requested a review from fpistm January 18, 2021 10:47
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @ABOSTM

@fpistm fpistm added this to the 2.0.0 milestone Jan 20, 2021
@fpistm fpistm merged commit 830daf0 into stm32duino:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#define MASTER_ADDRESS conflict
2 participants