DAC fixes #1326
Merged
DAC fixes #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For STM32F3 serie, depending on instance/channel used, output buffer may be replaced by output switch Both being exclusive, they can be both set in HAL structure. Fixes stm32duino#1324 Signed-off-by: Alexandre Bourdiol <[email protected]>
Fixes stm32duino#1324 Signed-off-by: Alexandre Bourdiol <[email protected]>
kiiv-cz
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DAC: STM32F3 dac may have output switch instead of output buffer
For STM32F3 serie, depending on instance/channel used,
output buffer may be replaced by output switch
Both being exclusive, they can be both set in HAL structure.
DAC: remove HAL_DAC_DeInit() to avoid other channel deconfiguration
Fixes #1324