Skip to content

Add I2C definition for RemRam V1 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Add I2C definition for RemRam V1 #417

merged 1 commit into from
Jan 25, 2019

Conversation

hasenbanck
Copy link
Contributor

I thought I had set the I2C pins to the arduino compatible
values, but it seems I messed that up. This change will
set the defaults for the board variant RemRam V1.

I thought I had set the I2C pins to the arduino compatible
values, but it seems I messed that up. This change will
set the defaults for the board variant RemRam V1.
@fpistm fpistm self-requested a review January 25, 2019 13:50
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, before, trying to use PB1 (D14) and PB0 (D15) while they are no I2C.
Nice catch.

@fpistm fpistm added the fix 🩹 Bug fix label Jan 25, 2019
@fpistm fpistm added this to the 1.5.0 milestone Jan 25, 2019
@fpistm fpistm merged commit bac96d1 into stm32duino:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants