Skip to content

[I2C] Harden error management #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2019
Merged

[I2C] Harden error management #608

merged 1 commit into from
Aug 26, 2019

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Aug 22, 2019

No description provided.

@fpistm fpistm added the fix 🩹 Bug fix label Aug 22, 2019
@fpistm fpistm added this to the 1.7.0 milestone Aug 22, 2019
@fpistm fpistm requested a review from LMESTM August 22, 2019 09:05
@fpistm fpistm self-assigned this Aug 22, 2019
LMESTM
LMESTM reviewed Aug 23, 2019
View reviewed changes
Copy link
Member

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some details in commit message of what error case this solves ? Was there some timing issue where HAL would report a timeout before this was actually detected locally ?

@fpistm
[I2C] Harden error management
8692901 
Example for I2C scanner fewer errors are reported.
Sometime there is a HAL_I2C_ERROR_TIMEOUT was raised but
not reported as I2C_TIMEOUT.
In a general way, mask have to be used to properly handle error cases.

Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm
Copy link
Member Author

fpistm commented Aug 23, 2019

Can you add some details in commit message of what error case this solves ? Was there some timing issue where HAL would report a timeout before this was actually detected locally ?

Some comment added in the commit message

@fpistm fpistm merged commit a8b801d into stm32duino:master Aug 26, 2019
@fpistm fpistm deleted the I2C_Error branch August 26, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMESTM LMESTM LMESTM approved these changes

Assignees

@fpistm fpistm

Labels
fix 🩹 Bug fix
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fpistm @LMESTM