fix: allow tests to pass with known rolldown-vite issue #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikg
commented
Jun 17, 2025
| }); | ||
| // this is known to fail, skip the test in our own CI but keep it in ecosystem-ci so that rolldown-vite-ecosystem-ci still gets this fail | ||
| // TODO remove skip once fixed | ||
| it.skipIf(rolldownVersion && !env.ECOSYSTEM_CI)( |
There was a problem hiding this comment.
this test is known to fail with rolldown-vite, to avoid local ci from being red all the time we skip it, but keep it active in ecosystem-ci so once the fix is in, we'll know and can remove this
benmccann
reviewed
Jun 20, 2025
Co-authored-by: Ben McCann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and log link to list of known issues.