-
Notifications
You must be signed in to change notification settings - Fork 342
[lldb] Add test for @objc @implementation #10889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: swift/release/6.2
Are you sure you want to change the base?
[lldb] Add test for @objc @implementation #10889
Conversation
@@ -0,0 +1,4 @@ | |||
SWIFT_SOURCES = main.swift | |||
SWIFT_BRIDGING_HEADER = Gadget.h | |||
SWIFT_PRECOMPILE_BRIDGING_HEADER = NO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity — why is this needed?
(It basically removes DWARF for the types in the header, so I'm curious if the test depends on the missing debug info)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the test depends on the absence of debug info (to emulate system or third party libraries). Is there a better way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the clangimported part, this is probably them most convenient solution. Maybe we could add a comment like
# This hides the debug info, to make sure ObjC metadata is being used to resolve the types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Could you also test what these fields look like from an Objective-C frame?
Add tests for SE-0436. Depends on swiftlang/swift#81967