Skip to content

[lldb] Add test for @objc @implementation #10889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: swift/release/6.2
Choose a base branch
from

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Jun 23, 2025

Add tests for SE-0436. Depends on swiftlang/swift#81967

@kastiglione kastiglione requested a review from a team as a code owner June 23, 2025 17:31
@kastiglione
Copy link
Author

swiftlang/swift#81967

@swift-ci test

@kastiglione
Copy link
Author

swiftlang/swift#81967

@swift-ci test

@kastiglione
Copy link
Author

swiftlang/swift#81967

@swift-ci test

@@ -0,0 +1,4 @@
SWIFT_SOURCES = main.swift
SWIFT_BRIDGING_HEADER = Gadget.h
SWIFT_PRECOMPILE_BRIDGING_HEADER = NO

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity — why is this needed?
(It basically removes DWARF for the types in the header, so I'm curious if the test depends on the missing debug info)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the test depends on the absence of debug info (to emulate system or third party libraries). Is there a better way to do this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the clangimported part, this is probably them most convenient solution. Maybe we could add a comment like

# This hides the debug info, to make sure ObjC metadata is being used to resolve the types.

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Could you also test what these fields look like from an Objective-C frame?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants