Skip to content

[lldb] Support step through plans for non-Swift symbols in SwiftLanguageRuntime (NFC) #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2021
Merged

[lldb] Support step through plans for non-Swift symbols in SwiftLanguageRuntime (NFC) #2457

merged 2 commits into from
Feb 12, 2021

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Feb 9, 2021 •
edited
Loading

To support Swift Concurrency, SwiftLanguageRuntime::GetStepThroughTrampolinePlan will add support for stepping through functions with non-Swift symbols, in other words C and/or C++.

Instead of calling GetThunkKind with a mangled name string, this small change passes in the Symbol, so that GetThunkKind can reference a Symbol's name as well.

@kastiglione
Copy link
Author

@swift-ci test

jimingham
jimingham approved these changes Feb 9, 2021
View reviewed changes
Copy link

@jimingham jimingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I think you can get rid of symbol_mangled_name as a drive-by cleanup, though that's not terribly important.

@kastiglione
Copy link
Author

@swift-ci test

1 similar comment
@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@swift-ci test Linux Platform

@kastiglione kastiglione force-pushed the lldb-Support-step-through-plans-for-non-Swift-symbols-in-SwiftLanguageRuntime-NFC branch from 2b210ae to 391267d Compare February 12, 2021 17:43
@kastiglione
Copy link
Author

@swift-ci test

@kastiglione kastiglione mentioned this pull request Feb 12, 2021
Merged
@kastiglione kastiglione merged commit 02e8350 into swift/main Feb 12, 2021
@kastiglione kastiglione deleted the lldb-Support-step-through-plans-for-non-Swift-symbols-in-SwiftLanguageRuntime-NFC branch February 12, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimingham jimingham jimingham approved these changes

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kastiglione @jimingham