Skip to content

Turn ENABLE_SDK_IMPORTS off by default for now #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

neonichu
Copy link
Collaborator

No description provided.

@neonichu
Copy link
Collaborator Author

@swift-ci please test

Copy link
Collaborator

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. you might need a handful of extra test updates, I'm not sure

@neonichu
Copy link
Collaborator Author

I think other tests should be fine since we're using an old Xcode in CI which auto opts us out of this feature anyway.

@neonichu neonichu enabled auto-merge (squash) February 19, 2025 22:14
@neonichu neonichu merged commit 68b0a58 into main Feb 19, 2025
1 of 3 checks passed
@neonichu neonichu deleted the bbuegling/sdk-imports-off-by-default branch February 19, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants