Skip to content

Update CMakeLists.txt #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

Update CMakeLists.txt #3155

merged 2 commits into from
Mar 16, 2022

Conversation

compnerd
Copy link
Member

Bump discovery timeout to see if it helps.

@compnerd
Update CMakeLists.txt
328c7ac 
Bump discovery timeout to see if it helps.
@compnerd compnerd mentioned this pull request Mar 15, 2022
Closed
@stevapple
Copy link
Contributor

This problem should go with #3146.

@compnerd Could you take some time to review that now?

@compnerd
Copy link
Member Author

compnerd commented Mar 16, 2022 •
edited
Loading

Why would that impact this?

@stevapple
Copy link
Contributor

stevapple commented Mar 16, 2022 •
edited
Loading

With #3146 , TestFoundation no longer requires anything to be in the path. (If you’re not meeting problems with this, go ahead. I have no problem running TestFoundation with that patch included.)

DLL paths will be injected by CMake.

@compnerd
Copy link
Member Author

Right, I understand that. I am not seeing the issue locally, only on the swift.org builder.

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd merged commit 2150d98 into main Mar 16, 2022
@compnerd compnerd deleted the compnerd/discovery-timeout branch March 16, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @stevapple