Update for SE-0107: Migrate Void->Raw. #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsafe[Mutable]Pointer<Void> is replaced by Unsafe[Mutable]RawPointer. Migrating often means simply removing casts to/from UnsafePointer<UInt8> and working directly with UnsafeRawPointer instead. Unfortunately some API's, like NSData still want UnsafePointer<UInt8>, which requires "binding" memory to UInt8 before passing it to the API.
Remove the generic parameter from NSObject withUnretainedReference. Raw pointers make it unnecessary and are incompatible with it. This is a source compatible change.
|
Depends on Swift PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsafe[Mutable]Pointer is replaced by Unsafe[Mutable]RawPointer.
Migrating often means simply removing casts to/from UnsafePointer
and working directly with UnsafeRawPointer instead.
Unfortunately some API's, like NSData still want UnsafePointer,
which requires "binding" memory to UInt8 before passing it to the API.