-
Notifications
You must be signed in to change notification settings - Fork 208
Revert "Switch to using clang as linker on darwin" #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Switch to using clang as linker on darwin" #1142
Conversation
@keith we are seeing failures in CI with:
Most likely because we removed the logic in this PR to add Could you please take a look? |
@swift-ci please test |
@DougGregor also pointed out that the issue is due to special logic in clang for this: Which isn't doing the right thing to find Xcode. Instead, it should be using:
|
So we can either re-add the removed logic for handling arclite back to this driver, or investigate fixing up what Clang driver is doing possibly incorrectly here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The Swift Driver does something a bit more robust than Clang, by checking if the |
I have a Clang fix that should work: swiftlang/llvm-project#5007 |
I have a PR to reinstate this in #1143 |
Reverts #1111