Skip to content

Fix a non-deterministic failure in testPrintingExplicitDependencyGraph #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Contributor

When JSONEncoder puts mainModuleName in the end of the JSON dictionary, it does not have , in the end. Remove the trailing , to avoid such failures.

When JSONEncoder puts `mainModuleName` in the end of the JSON
dictionary, it does not have `,` in the end. Remove the trailing `,` to
avoid such failures.
@cachemeifyoucan cachemeifyoucan requested a review from artemcm July 3, 2023 18:04
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@artemcm artemcm merged commit 07277b7 into swiftlang:main Jul 3, 2023
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-fix-test-printing-dep-graph-json branch July 3, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants