[ABIChecking] Use -Isystem and -Fsystem for swift-api-digester #1933
Conversation
ian-twilightcoder
requested review from
owenv,
nkcsgexi,
artemcm and
cachemeifyoucan
swift-api-digester supports the Swift -Fsystem and -Isystem flags, switch to those. rdar://152747553
ian-twilightcoder
force-pushed
the
swift-api-digester-args
branch
from
56a89f5 to
3f3a67d
Compare
|
@swift-ci test |
|
Depends on swiftlang/swift#82283 |
| commandLine.appendFlag(.iframework) | ||
| commandLine.appendFlag(systemFramework.argument.asSingle) | ||
| } | ||
| try commandLine.appendAll(.I, .Isystem, from: &parsedOptions) |
There was a problem hiding this comment.
Hmm, we do not have a way to test whether the selected toolchain's swift-api-digester supports this as a SwiftAPIDigesterOption. Since the flag itself is not new to the compiler, what happens when this gets passed to a swift-api-digester which predates swiftlang/swift#82283?
There was a problem hiding this comment.
Prior to swiftlang/swift#82283 the argument will just be lost because the digester won't try to read -Isystem or -Fsystem. There's nothing in swiftscan that I can see to get api-digester args. The strings it returns from swiftscan_compiler_supported_arguments_query don't include the flags like SwiftAPIDigesterOption. And swift-api-digester doesn't support -emit-supported-features either.
There was a problem hiding this comment.
FWIW though, swift-build doesn't currently use -iframework, -Fsystem, or -Isystem when it makes digester jobs.
There was a problem hiding this comment.
swiftpm also doesn't use -iframework in its digester jobs, as far as I can tell.
swift-api-digester supports the Swift -Fsystem and -Isystem flags, switch to those.
rdar://152747553