Skip to content

Guard emission of variant module behind a flag #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 26, 2025

No description provided.

@artemcm artemcm requested a review from etcwilde June 26, 2025 23:54
@artemcm
Copy link
Contributor Author

artemcm commented Jun 26, 2025

@swift-ci test

@artemcm artemcm marked this pull request as ready for review June 27, 2025 16:06
@etcwilde
Copy link
Member

testTargetVariantEmitModuleExplicit needs to pass the new flag or it doesn't have the two module jobs and explodes.

@artemcm artemcm force-pushed the NewDriverComboEmitVariantModuleFlag branch from ef85bde to 5bdba78 Compare June 27, 2025 16:44
@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2025

@swift-ci test

@artemcm artemcm enabled auto-merge (rebase) June 27, 2025 16:46
@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2025

@swift-ci test Windows platform

@artemcm artemcm force-pushed the NewDriverComboEmitVariantModuleFlag branch from 5bdba78 to 38be297 Compare June 27, 2025 22:53
@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 28, 2025

@swift-ci please test Windows

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Jun 30, 2025

@swift-ci please test Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants