Skip to content

[Build Script Helper] Make cleaning up build directory a separate "clean" action. #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Aug 20, 2020

Instead of doing it automatically every time.
This will allow callers (mostly swift build-script) decide/override whether or not cleanup should be done.
swiftlang/swift#33563 shows the use of this action in the compiler's build-script.

…ean" action.

Instead of doing it automatically every time.
This will allow callers (mostly `swift` `build-script`) decide/override whether or not cleanup should be done.
@artemcm artemcm requested a review from DougGregor August 20, 2020 18:32
@artemcm
Copy link
Contributor Author

artemcm commented Aug 20, 2020

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is helpful

@artemcm
Copy link
Contributor Author

artemcm commented Aug 20, 2020

@swift-ci please test

@artemcm artemcm merged commit 00c3d81 into swiftlang:master Aug 20, 2020
@artemcm artemcm deleted the BuildHelperCleanStage branch January 20, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants