Skip to content

[DNM] Revert disabling tests on Apple Silicon #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[DNM] Revert disabling tests on Apple Silicon #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ccd9f1
Revert disabling tests on Apple Silicon
artemcm Apr 22, 2021
4217203
Add diagnostic prints on job failure
artemcm Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Sources/SwiftDriverExecution/MultiJobExecutor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,13 @@ class ExecuteJobRule: LLBuildRule {
let result = try process.waitUntilExit()
let success = result.exitStatus == .terminated(code: EXIT_SUCCESS)


if !success {
print("Job failure: \(job)")
print("Output: \(try result.utf8Output())")
print("Err Output: \(try result.utf8stderrOutput())")
}

if !success {
switch result.exitStatus {
case let .terminated(code):
Expand Down
17 changes: 0 additions & 17 deletions Tests/SwiftDriverTests/JobExecutorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,6 @@ extension DarwinToolchain {
final class JobExecutorTests: XCTestCase {
func testDarwinBasic() throws {
#if os(macOS)
#if arch(arm64)
// Disabled on Apple Silicon
// rdar://76609781
throw XCTSkip()
#endif

let executor = try SwiftDriverExecutor(diagnosticsEngine: DiagnosticsEngine(),
processSet: ProcessSet(),
fileSystem: localFileSystem,
Expand Down Expand Up @@ -221,11 +215,6 @@ final class JobExecutorTests: XCTestCase {
/// Ensure the executor is capable of forwarding its standard input to the compile job that requires it.
func testInputForwarding() throws {
#if os(macOS)
#if arch(arm64)
// Disabled on Apple Silicon
// rdar://76609781
throw XCTSkip()
#endif
let executor = try SwiftDriverExecutor(diagnosticsEngine: DiagnosticsEngine(),
processSet: ProcessSet(),
fileSystem: localFileSystem,
Expand Down Expand Up @@ -456,12 +445,6 @@ final class JobExecutorTests: XCTestCase {
}

func testSaveTemps() throws {
#if os(macOS) && arch(arm64)
// Disabled on Apple Silicon
// rdar://76609781
throw XCTSkip()
#endif

do {
try withTemporaryDirectory { path in
let main = path.appending(component: "main.swift")
Expand Down