Skip to content

[SE-0371] Isolated synchronous deinit #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 18, 2022

Conversation

nickolas-pohilets
Copy link
Contributor

No description provided.

@nickolas-pohilets nickolas-pohilets changed the title Isolated synchronous deinit [SE-NNNN] Isolated synchronous deinit Jul 29, 2022
@DougGregor
Copy link
Member

@swift-ci please test

@jumhyn-duolingo
Copy link

@DougGregor I'm assuming you indented to comment on the implementation PR? :)

@DougGregor
Copy link
Member

Hah! So I did

Copy link
Member

@Jumhyn Jumhyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a first pass through, looks pretty good overall. I have a slough of minor drafting suggestions as well as a couple places we could probably beef up the argumentation a bit.

@Jumhyn Jumhyn changed the title [SE-NNNN] Isolated synchronous deinit [SE-0371] Isolated synchronous deinit Aug 18, 2022
@Jumhyn Jumhyn merged commit 9ccfd28 into swiftlang:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants