Skip to content

Proposal to formalize 'language mode' terminology #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2024
Merged

Proposal to formalize 'language mode' terminology #2474

merged 4 commits into from
Jul 15, 2024

Conversation

dempseyatgithub
Copy link
Contributor

Proposal to formalize the term language mode in tool options and Swift PM APIs.

Most discussion occurred in the first pitch thread

The proposal has a Swift PM implementation which has passed CI tests and has an approval.

@dempseyatgithub
Add proposal to formalize 'language mode' terminology
2993e77 
Proposal to formalize the term 'language mode' in tool options and Swift PM APIs.
@rjmccall rjmccall added the LSG Contains topics under the domain of the Language Steering Group label Jun 24, 2024
@rjmccall
Copy link
Contributor

Okay, two pieces of LSG feedback here about the design:

  • Please just immediately deprecate the swiftLanguageVersion API from SE-0435 rather than removing it entirely. There's no harm in having both of these, and we should point the people who've started adopting this at the new API.
  • The swiftLanguageVersions property and SwiftVersion type should be deprecated in the 6.0 tools version rather than obsoleted. Obsolescence on the initializer is necessary in order to deal with the ambiguity when the argument isn't provided at all, but we should be less demanding when it isn't required.

We'll try to find someone to help you with the driver implementation here.

@dempseyatgithub
Copy link
Contributor Author

Thank you for the feedback. I will be making these changes in the next few days.

@dempseyatgithub
Incorporate LSG feedback
27258ad 
- Make swiftLanguageVersions property deprecated not obsoleted
- Deprecate Swift setting added in SE-0435 in favor of renamed setting
- Add Acknowledgments section
- Fix typos
@dempseyatgithub
Copy link
Contributor Author

I've incorporated the feedback and updated the proposal.

@rjmccall rjmccall merged commit b9e1aae into swiftlang:main Jul 15, 2024
@rjmccall
Copy link
Contributor

Do we have any sort of integrated toolchain with all of these changes applied, across both Swift and SPM?

@xedin xedin mentioned this pull request Jul 15, 2024
Closed
@xedin
Copy link
Contributor

xedin commented Jul 15, 2024

Toolchain built for SwiftPM changes - swiftlang/swift#73908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
LSG Contains topics under the domain of the Language Steering Group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dempseyatgithub @rjmccall @xedin