Skip to content

[6.2] swift-testing test fixes #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

jmschonfeld
Copy link
Contributor

  • Explanation: Cherry-picks two fixes made to account for issues introduced by swift-testing's parallelism back to 6.2
  • Scope: Mostly impacts unit test code only, with a small impact to JSON/PropertyList decoding when parsing numbers
  • Original PRs: Prevent decimal_withFormat_localeDependent from relying on the current locale #1428, Update stringshims to always use clocale #1427
  • Risk: Low - mostly impacts unit tests and non-unit test impact has good coverage with extensive local testing
  • Testing: We've seen this failures stop appearing in mainline CI now that they've landed there for a few days, and we've done extensive local testing with these changes to ensure that the nondeterministic failures are eliminated
  • Reviewers: @kperryua @itingliu

@jmschonfeld jmschonfeld requested review from parkera and itingliu July 17, 2025 16:24
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld merged commit d707b2f into swiftlang:release/6.2 Jul 17, 2025
16 checks passed
@jmschonfeld jmschonfeld deleted the 6.2/test-fixes branch July 17, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants