-
Notifications
You must be signed in to change notification settings - Fork 43
Reflect variant name in directory ids #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a s/toolchains_assert/toolchain_assert/
? The use is for a single toolchain installation right?
changed to use singular toolchain |
The installer built properly the test failures are unrelated. |
6381eef
to
51aadac
Compare
51aadac
to
e9c89e6
Compare
This is a follow up change to #428. In this PR we are making directory IDs reflect the variant in the name of the install directory (e.g.
Swift\Toolchains\6.2.0+Asserts\usr
).There is no functional change in this change, it is just directory ids. Directory names and which components are installed to which directories should not be changed.
This should make it easier to add new variants by following the same pattern, and will allow us to parametrize authoring that is shared between variants.
Naming convention:
ToolchainsVersioned
becameToolchainsVersionedAsserts
-- this is our top-level toolchain install directory likeSwift\Toolchains\0.0.0+Asserts
_usr_share
becametoolchains_asserts_usr_share
to reflect the full path at install time i.e.``Swift\Toolchains\0.0.0+Asserts\usr\share`