[CMake][llbuildSwift] fix runpath for ELF platforms #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the absolute path to the host toolchain's stdlib from libllbuildSwift.so.
|
Btw, I also just noticed this broken relative rpath in the official 5.2.3 release for linux: That may also be worth fixing separately in the 5.2 branch, though given that nobody noticed so far, maybe not. |
|
@swift-ci please smoke test |
|
OS X failure looks spurious as this pull only affects linux, which passes. |
|
@swift-ci please smoke test osx |
1 similar comment
|
@swift-ci please smoke test osx |
|
@swift-ci please smoke test |
dmbryson
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the absolute path to the host toolchain's stdlib from libllbuildSwift.so.
Otherwise, you see the following in the latest official 5.3 snapshot release for linux: