Temporarily skip a Swift Build test to allow staging in changes to the test product type. #8758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e test product type
owenv
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
owenv
commented
Jun 3, 2025
| @@ -4081,14 +4081,13 @@ class PackageCommandSwiftBuildTests: PackageCommandTestCase { | |||
| throw XCTSkip("SWBINTTODO: Build plan is not currently supported") | |||
| } | |||
|
|
|||
| #if !os(macOS) | |||
There was a problem hiding this comment.
Testing locally this test works for me on macOS, so I don't think this is needed anymore
|
@swift-ci test |
jakepetroules
approved these changes
Jun 4, 2025
owenv
added a commit
to owenv/swift-package-manager
that referenced
this pull request
Jun 4, 2025
…es to the test product type. (swiftlang#8758)" This reverts commit 609592e.
owenv
added a commit
to owenv/swift-package-manager
that referenced
this pull request
Jun 9, 2025
…es to the test product type. (swiftlang#8758)" This reverts commit 609592e.
owenv
added a commit
to owenv/swift-package-manager
that referenced
this pull request
Jun 10, 2025
…es to the test product type. (swiftlang#8758)" This reverts commit 609592e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're staging in changes so tests build as dylibs with a separate runner executable on non-Darwin platforms, which more closely matches the native build system. Skip this test temporarily as it will fail after the Swift Build changes land but before the SwiftPM ones do, to avoid the need for coordinated merges