Provide library paths to plugin tools when run as custom tasks #8767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri and
daveyc123
as code owners
|
@swift-ci please test |
jakepetroules
requested changes
Jun 4, 2025
Use path handling logic from Environment
…ion of runtime library paths
|
@swift-ci please test |
|
@swift-ci test Windows |
bkhouri
reviewed
Jun 5, 2025
| @@ -182,7 +172,7 @@ final class PluginTests: XCTestCase { | |||
| XCTAssert(stdout.contains("Build complete!"), "stdout:\n\(stdout)") | |||
| } | |||
|
|
|||
| #if os(macOS) // See https://github.com/swiftlang/swift-package-manager/issues/8416 for errors running build tools on Linux | |||
| #if os(macOS) | |||
There was a problem hiding this comment.
question: are these tests not supported on other platform, or they currently fail? If they later, can we convert this Suite to Swift Testing and make use of the withKnownIssue API instead of skipping the test? This would allow us to "re-enable" the test once the production code gets at par.
There was a problem hiding this comment.
It's the latter. I can try and convert these to Swift Testing in a future PR and then we will get notification when features start working, such as with Windows.
jakepetroules
approved these changes
Jun 5, 2025
|
@swift-ci please test |
|
@swift-ci test Windows |
|
@swift-ci test Linux |
|
@swift-ci test macOS |
|
@swift-ci please test |
|
@swift-ci test Windows |
owenv
added a commit
that referenced
this pull request
Jun 10, 2025
swiftlang/swift-build#558 and #8767 had a test/merge race which caused a failure in this test on linux. Add a narrow skip to this brand new test until these changes are working together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux build tool plugins won't work because they require a library
path to the Swift standard libraries. Add the toolchain's library path
to the environment for the custom task. Enable the tests that cover
this area for non-macOS platforms.