Skip to content

Add support for a Package-config.json to specify defaults for environment variables #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 19, 2022

When opening the project in Xcode, I always needed to edit the package manifest to point to the correct SourceKit search path, undo the changes to rebase etc. That's annoying.

Allow the a Package-config.json next to the Package.swift file, which is consulted for default values for the environment variables (environment variables still take precedence). That config file is in .gitignore, so it can persist between git operations.

…ment variables

When opening the project in Xcode, I always needed to edit the package manifest to point to the correct SourceKit search path, undo the changes to rebase etc. That's annoying.

Allow the a `Package-config.json` next to the `Package.swift` file, which is consulted for default values for the environment variables (environment variables still take precedence). That config file is in `.gitignore`, so it can persist between git operations.
@ahoppen ahoppen requested a review from bnbarham January 19, 2022 09:11
@ahoppen
Copy link
Member Author

ahoppen commented Jan 19, 2022

@swift-ci Please test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll make it much nicer, good idea!

@ahoppen ahoppen merged commit 8f49297 into swiftlang:main Jan 20, 2022
@ahoppen ahoppen deleted the pr/package-config branch January 20, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants