[Parser] Improve FixIt for function parameter with missing type (name1 Name2)
#1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
May 19, 2023
TiagoMaiaL
force-pushed
the
fix-colon-fixit-for-function-signature
branch
from
ae274fa to
73a3a6c
Compare
If the `node.secondName` starts with a capital letter, we now assume the user wanted it to be the type of the parameter. This commit makes the following changes to the FixIt of `name1 Name2`: - from `name1 Name2: TypeText` - to `name1: Name2`
TiagoMaiaL
force-pushed
the
fix-colon-fixit-for-function-signature
branch
from
73a3a6c to
b4396f9
Compare
|
Do we need the comment in func testInvalid13() {
// https://github.com/apple/swift/issues/43190
// Crash with invalid parameter declaration |
ahoppen
approved these changes
May 19, 2023
There was a problem hiding this comment.
Thank you for your contribution @TiagoMaiaL. This looks very good to me!
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To solve issue #1608.
Notes
There are some
TODOsin the code I want to solve but I didn't know how. Any help is appreciated. Thank you.