Balance spacing around =
#1694
Merged
Balance spacing around =
#1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
commented
May 23, 2023
Tests/SwiftParserTest/translated/DiagnoseInitializerAsTypedPatternTests.swift
Outdated
Show resolved
Hide resolved
ahoppen
reviewed
May 23, 2023
kimdv
force-pushed
the
kimdv/1609-space-is-not-balanced-around-=-for-fix-its
branch
from
b0929a1 to
9b84e5c
Compare
When the leading or trailing trivia was empty it was replacing the present nodes trivias
kimdv
force-pushed
the
kimdv/1609-space-is-not-balanced-around-=-for-fix-its
branch
from
9b84e5c to
43927e8
Compare
kimdv
commented
May 24, 2023
| @@ -978,7 +979,7 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor { | |||
| fixIts: [ | |||
| FixIt( | |||
| message: ReplaceTokensFixIt(replaceTokens: [.binaryOperator("==")], replacements: [node.equal]), | |||
| changes: [.makeMissing(unexpected), .makePresent(node.equal, leadingTrivia: [])] | |||
There was a problem hiding this comment.
I found two places where we don't need to add trivia
There was a problem hiding this comment.
Nice. I suspect there might be a few more as well. Haven’t checked though.
There was a problem hiding this comment.
Tried to do a quick look, didn't find any
There was a problem hiding this comment.
OK, maybe there aren’t any more left. Even better. It was just a gut feeling without looking at the code.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the leading or trailing trivia was empty it was replacing the present nodes trivias