When handling a missing layout node, only make the placeholder present #1894
Conversation
Since `SourceLocation` is no longer `ExpressibleByDebugDescription` due to the addition of `presumedFile` and `presumedLine`, we need to manually print just line and column here.
ahoppen
force-pushed
the
ahoppen/missing-nodes-fixit
branch
from
5bcee2d to
d51cdce
Compare
|
@swift-ci Please test |
| let changes = missingNodes.map { node in | ||
| if let missing = node.asProtocol(MissingNodeSyntax.self) { | ||
| // For missing nodes, only make the placeholder present. Don’t make any | ||
| // missing nodes, e.g. in a malformed attribute, missing. |
There was a problem hiding this comment.
| // missing nodes, e.g. in a malformed attribute, missing. | |
| // missing nodes, e.g. in a malformed attribute, present. |
There was a problem hiding this comment.
Out of interest, what other nodes were being made present? In eg. the @resultBuilder test case, I would have expected the MissingDeclSyntax to just have @resultBuilder + the placeholder token.
There was a problem hiding this comment.
@_specialize(ewhich contained a missing :, identifier and ) in the attribute of the MissingDeclSyntax, which was made present by the Fix-It.
Are you planning on adding docs for the other traits as well? |
This fixes a couple of formatting issues and resolves the question raised in swiftlang#1727 (comment).
ahoppen
force-pushed
the
ahoppen/missing-nodes-fixit
branch
from
d51cdce to
caddfd1
Compare
I am planning to add documentation to the traits as much as I’m planning to add documentation to all the syntax nodes. How soon I/the community will get to it 🤷🏽♂️ |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
This fixes a couple of formatting issues and resolves the question raised in #1727 (comment).
While at it do the following
debugDescriptionofDiagnosticSourceLocationis no longerExpressibleByDebugDescriptiondue to the addition ofpresumedFileandpresumedLine, we need to manually print just line and column here.