Miscellaneous bookkeeping/cleanup of _TestDiscovery
.
#1055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few minor changes:
DiscoverableAsTestContent._testContentTypeNameHint
is not present ifSWT_NO_LEGACY_TEST_DISCOVERY
is defined;TestContentKind.init(stringLiteral:)
so it doesn't callutf8CodeUnitCount
on single-character static strings;TestContentKind._fourCCValue
usesisprint()
to check if the kind value looks like a FourCC rather than calling ICU-based functions;SectionBounds.Kind.segmentAndSectionName
; andTestContentKind.commentRepresentation
(in the macro target).Checklist: