Skip to content

[6.2] Don't use a class to store the current exit test. #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[6.2] Don't use a class to store the current exit test. #1066

merged 1 commit into from
Apr 9, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Apr 9, 2025 •
edited
Loading

@grynspan
Don't use a class to store the current exit test. (#1065)
d2cf2ca 
This PR replaces the private `_CurrentContainer` class used to store the
current exit test with a bare pointer. The class is prone to duplicate
definitions, but we really just use it as a glorified box type for the
move-only `ExitTest`, so an immortal pointer will work just as well.

Works around rdar://148837303.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support workaround Workaround for an issue in another component (may need to revert later) exit-tests ☠️ Work related to exit tests labels Apr 9, 2025
@grynspan grynspan added this to the Swift 6.2 milestone Apr 9, 2025
@grynspan grynspan self-assigned this Apr 9, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Apr 9, 2025

@swift-ci test

@grynspan grynspan merged commit 9810afe into release/6.2 Apr 9, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/148837303-exittest-container-duplicate-6.2 branch April 9, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briancroom briancroom briancroom approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support exit-tests ☠️ Work related to exit tests workaround Workaround for an issue in another component (may need to revert later)
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @briancroom