order limits.h before stdlib.h to workaround for glibc _FORTIFY_SOURCE #1184
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoward
requested review from
stmontgomery,
grynspan,
briancroom and
suzannaratcliff
as code owners
lhoward
added a commit
to PADL/meta-swift
that referenced
this pull request
Jun 28, 2025
`limits.h` must be included before `stdlib.h` when building with glibc and having `_FORTIFY_SOURCE` set to a non-zero value. When building with `_FORTIFY_SOURCE`, `realpath()` is inlined, and its definition depends on whether `limits.h` has been included or not (clearly, this is a terrible idea in terms of interacting with Clang modules and should probably be fixed upstream). If the definition differs from the one in SwiftGlibc, then _TestingInternals will not build. swiftlang/swift-testing#1184
grynspan
requested changes
Jun 28, 2025
grynspan
added
bug
|
@swift-ci test |
|
Obviously we could also conditionalise this based on platform but I presume it's generally safe to include |
Yes, will do. |
`limits.h` must be included before `stdlib.h` when building with glibc and having `_FORTIFY_SOURCE` set to a non-zero value. When building with `_FORTIFY_SOURCE`, `realpath()` is inlined, and its definition depends on whether `limits.h` has been included or not (clearly, this is a terrible idea in terms of interacting with Clang modules and should probably be fixed upstream). If the definition differs from the one in SwiftGlibc, then _TestingInternals will not build.
|
Is there a URL we can point to tracking the issue in glibc? |
I haven't filed a bug yet, will do (sorry, it's Sunday, negotiating bug fixing around family life!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limits.hmust be included beforestdlib.hwhen building with glibc and having_FORTIFY_SOURCEset to a non-zero value.When building with
_FORTIFY_SOURCE,realpath()is inlined, and its definition depends on whetherlimits.hhas been included or not (clearly, this is a terrible idea in terms of interacting with Clang modules and should probably be fixed upstream). If the definition differs from the one in SwiftGlibc, then _TestingInternals will not build.