[6.2] FreeBSD: Gate GNU-only API #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FreeBSD builds are currently using the GlibC modulemap to import the C runtimes. FreeBSD does not have `gnu_get_libc_version` resulting in build failures. The use of this API was introduced in swiftlang#1147 (cherry picked from commit 79c22ad) - **Explanation**: The FreeBSD builds are currently using the GlibC modulemap to import the C runtimes. FreeBSD does not have `gnu_get_libc_version` resulting in build failures. - **Scope**: Build failure on platforms using Glibc modulemap that don't have GNU extensions. (FreeBSD, OpenBSD) - **Issues**: swiftlang#1193 - **Original PRs**: swiftlang#1183 - **Risk**: Low risk. Removes use of unavailable API. - **Testing**: Built swift-testing on FreeBSD and Linux. - **Reviewers**: @grynspan @3405691582 Fixes: swiftlang#1193
etcwilde
requested review from
stmontgomery,
grynspan,
briancroom and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
changed the title
grynspan
approved these changes
Jul 2, 2025
briancroom
approved these changes
Jul 2, 2025
grynspan
added
bug
grynspan
added
workaround
|
@etcwilde Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FreeBSD builds are currently using the GlibC modulemap to import the C runtimes. FreeBSD does not have
gnu_get_libc_versionresulting in build failures.The use of this API was introduced in
#1147
(cherry picked from commit 79c22ad)
gnu_get_libc_versionresulting in build failures.Fixes: #1193