[SR-12732] 3 AutoDiff test failures: crashing in SIL verification #55177
Description
| Previous ID | SR-12732 |
| Radar | rdar://problem/62861476 |
| Original Reporter | @atrick |
| Type | Bug |
| Status | Resolved |
| Resolution | Done |
Attachment: Download
Additional Detail from JIRA
| Votes | 0 |
| Component/s | Swift for TensorFlow |
| Labels | Bug |
| Assignee | @dan-zheng |
| Priority | Medium |
md5: fe5666948dd165e8cdf8544062e8c9a5
Issue Description:
Latest Failures:
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator//3149/consoleFull
First Failure:
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/3138/consoleFull
Failing Tests (3):
06:26:12 Swift(macosx-x86_64) :: AutoDiff/validation-test/derivative_registration.swift
06:26:12 Swift(macosx-x86_64) :: AutoDiff/validation-test/custom_derivatives.swift
06:26:12 Swift(macosx-x86_64) :: AutoDiff/stdlib/derivative_customization.swift
See attached error.log or above URL
Possibly from:
commit 738ef73
Author: Dan Zheng <[email protected]>
Date: Mon May 4 00:44:48 2020 -0700
[AutoDiff] Fix `@differentiable` attribute derivative configurations. (#31524)
In `AbstractFunctionDecl::getDerivativeFunctionConfigurations`, type-check
`@differentiable` attributes. This is important to populate derivative
configurations for original functions in other files.
Resolves TF-1271.
Exposes TF-1272: fix derivative configurations for cross-file `@derivative`
attributes. This is a more difficult issue.
Commits from the blame list:
Commit 87b8f79 by pyaskevich
[AST] Extend ASTNode to support Pattern/TypeLoc
The file was modified lib/AST/ASTNode.cpp
The file was modified include/swift/AST/Pattern.h
The file was modified include/swift/AST/ASTNode.h
The file was modified lib/AST/ASTDumper.cpp
Commit 955f0f3 by pyaskevich
[ConstraintSystem] Switch `ConstraintLocator` to use `ASTNode` as an
anchor type
The file was modified lib/Sema/ConstraintLocator.cpp
The file was modified lib/Sema/ConstraintLocator.h
Commit 99ef865 by pyaskevich
[Diagnostics] Switch `FailureDiagnostic` to use `ASTNode` instead of
`TypedNode`
The file was modified lib/Sema/CSDiagnostics.h
The file was modified lib/Sema/CSDiagnostics.cpp
Commit 0b4404b by pyaskevich
[AST/Parser] Convert `TypeLoc` struct into aligned class
The file was modified include/swift/AST/TypeLoc.h
The file was modified include/swift/AST/ASTPrinter.h
The file was modified include/swift/Subsystems.h
The file was modified include/swift/AST/TypeCheckRequests.h
The file was modified include/swift/AST/ASTNode.h
The file was modified include/swift/Parse/Parser.h
The file was modified include/swift/AST/ASTWalker.h
The file was modified include/swift/AST/TypeAlignments.h
The file was modified lib/Sema/ConstraintLocator.h
Commit bd09d0c by pyaskevich
[ConstraintSystem] Switch `ConstraintFix` to use `ASTNode` instead of
`TypedNode`
The file was modified lib/Sema/CSFix.h
The file was modified lib/Sema/CSFix.cpp
Commit a483b34 by pyaskevich
[AST] Drop `const` qualifier from `{get/set}Type` callbacks
The file was modified lib/AST/Expr.cpp
The file was modified include/swift/AST/Expr.h
The file was modified lib/Sema/TypeCheckConstraints.cpp
The file was modified lib/Sema/CSApply.cpp
The file was modified lib/AST/ASTDumper.cpp
Commit 326b371 by pyaskevich
[ConstraintSystem] Switch auxiliary functions to use `ASTNode` instead
of `TypedNode`
The file was modified lib/Sema/CSSolver.cpp
The file was modified lib/Sema/CSSimplify.cpp
The file was modified lib/Sema/CSRanking.cpp
The file was modified lib/Sema/ConstraintSystem.cpp
The file was modified lib/Sema/ConstraintSystem.h
Commit 740a2dd by pyaskevich
[ConstraintSystem] NFC: Inline `ConstraintLocator::directlyAt`
implementation into the header
The file was modified lib/Sema/ConstraintLocator.h
The file was modified lib/Sema/ConstraintLocator.cpp