[ClangImporter] Record C declarations found in @interfaces. #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(including both classes and categories, and also @protocol declarations) This is a hack in that we use two different mechanisms for importing bridging header decls now: the manual output of ParseTopLevelDecl, and the callbacks of a clang::ASTConsumer. We should probably unify these, but that's a bigger change that isn't as obviously safe. Also note that we probably aren't getting this right for things included with -include, which we already don't have a good model for. This adds test cases for both the module and bridging header cases, although the former worked correctly already. rdar://problem/24806068
|
@swift-ci please test |
DougGregor
added a commit
that referenced
this pull request
Mar 14, 2016
[ClangImporter] Record C declarations found in @interfaces.
jrose-apple
pushed a commit
to jrose-apple/swift
that referenced
this pull request
Mar 30, 2016
…terface [ClangImporter] Record C declarations found in @interfaces. (cherry picked from commit c7dfed7)
1 task
DougGregor
added a commit
to DougGregor/swift
that referenced
this pull request
Apr 29, 2016
…terface [ClangImporter] Record C declarations found in @interfaces. (cherry picked from commit c7dfed7)
MaxDesiatov
pushed a commit
that referenced
this pull request
Oct 19, 2020
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(including both classes and categories, and also @protocol declarations)
This is a hack in that we use two different mechanisms for importing
bridging header decls now: the manual output of ParseTopLevelDecl, and
the callbacks of a clang::ASTConsumer. We should probably unify these,
but that's a bigger change that isn't as obviously safe.
Also note that we probably aren't getting this right for things included
with -include, which we already don't have a good model for.
This adds test cases for both the module and bridging header cases,
although the former worked correctly already.
rdar://problem/24806068