-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Implement Equatable/Comparable sequence algos in terms predicate ones #14758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@swift-ci please smoke benchmark |
Build comment file:Optimized (O)Regression (3)
Improvement (4)
No Changes (371)
Unoptimized (Onone)Regression (16)
Improvement (18)
No Changes (344)
Hardware Overview
|
Excellent! It is tempting to de-gyb this file entirely, given it's now down to documentation duplication. @natecook1000 what's your take? |
1e0abd9
to
89bac6a
Compare
@swift-ci please test |
@swift-ci please benchmark |
@swift-ci please smoke test compiler performance |
Build comment file:Optimized (O)Regression (1)
No Changes (377)
Unoptimized (Onone)Regression (9)
Improvement (9)
No Changes (360)
Hardware Overview
|
@swift-ci please test compiler performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De-gybbing sounds good—CollectionAlgorithms is already like that, so 👍
89bac6a
to
3243df8
Compare
@swift-ci please test |
@swift-ci please test compiler performance |
Build comment file:Summary for master fullUnexpected test results, stats may be off for FAIL_siesta-Siesta.xcodeproj_3.0_BuildXcodeProjectTarget_Siesta-macOS_generic-platform-macOS.log, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-tvOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-RxDataSources_generic-platform-iOS.log, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-iOS.log, FAIL_JSQDataSourcesKit-JSQDataSourcesKit.xcodeproj_4.0_BuildXcodeProjectTarget_JSQDataSourcesKit-iOS_generic-platform-iOS.log, FAIL_Dollar-Dollar.xcodeproj_3.0_BuildXcodeProjectScheme_Dollar_generic-platform-macOS.log, 3, FAIL_Kronos-Kronos.xcodeproj_3.0_BuildXcodeProjectTarget_Kronos_generic-platform-macOS.log, FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-Example_generic-platform-iOS.log No regressions above thresholds Debugdebug briefRegressed (0)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
debug detailedRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
Debug-optdebug-opt briefRegressed (0)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
debug-opt detailedRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
Wmo-ononewmo-onone briefRegressed (0)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (1)
wmo-onone detailedRegressed (0)
Improved (2)
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
Releaserelease briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
release detailedRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
|
Raising this PR mainly for benchmarking, expecting the benchmarks to regress, but if they don't, this should be a code-size win.