Skip to content

[func-sig-opts] Add a new mangling for the guaranteed->owned transfor… #16196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

…mation.

I followed the example of the owned->guaranteed transformation.

rdar://38196046

…mation.

I followed the example of the owned->guaranteed transformation.

rdar://38196046
@gottesmm gottesmm requested a review from eeckstein April 26, 2018 23:38
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@slavapestov
Copy link
Contributor

@rajbarik You might want to check out the code being edited by @gottesmm here -- it will give you ideas for how to implement the mangling for your existential specialization pass.

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gottesmm gottesmm merged commit ae14c16 into swiftlang:master Apr 27, 2018
@gottesmm gottesmm deleted the pr-b7bd0c9de669757c7b00339a8f30e79f6ff1e7c2 branch April 27, 2018 17:01
@rajbarik
Copy link
Contributor

rajbarik commented May 10, 2018 via email

@eeckstein
Copy link
Contributor

@rajbarik In general yes. The old remangler is used to create runtime type names.
But for your change, no. A specialized function cannot be the context of a type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants